Евтим обнови решението на 31.10.2022 19:23 (преди над 1 година)
+def get_letter_from_number_and_counter(number, counter):
+ start_of_alphabet_in_integer = 96
Бих използвал ord('a'), за да взема тази стойност динамичо. Не че някой ще променя ASCII таблицата, но в други подобни случаи би било полезно.
+ normalized_counter = 0
+ if number <= 6 or number == 8:
+ normalized_counter = counter % 3
+
+ if normalized_counter == 0:
+ normalized_counter = 3
+ elif number == 9 or number == 7:
Ако проверяваш дали стойност е равна на други стойнист, прието е (а и е по-лесно):
number in (7, 9)
+ normalized_counter = counter % 4
+
+ if normalized_counter == 0:
+ normalized_counter = 4
+
+ normalized_number = 0
+ normalized_number = number - 2
+ position_in_alphabet = 0
+ if number >= 2 and number <= 7:
+ position_in_alphabet = normalized_number*3 + normalized_counter
+ return chr(start_of_alphabet_in_integer + position_in_alphabet)
+ elif number == 8:
+ position_in_alphabet = normalized_number*3 + normalized_counter + 1 # +1 because of the 4 letters in '7'
+ return chr(start_of_alphabet_in_integer + position_in_alphabet)
+ elif number == 9:
+ position_in_alphabet = normalized_number*3 + normalized_counter + 2 # +2 because of the 4 letters in '7'
+ return chr(start_of_alphabet_in_integer + position_in_alphabet)
+ elif number == 0:
+ return " "
+ else:
+ return ""
+
+def nums_to_text(nums):
+ result = ''
+ nums_length = len(nums)
А защо не използваш директно len(nums)? Хем спестяваш променлива, хем е по-кратко.
+ repetead_numbers_counter = 0
+
+ if nums_length > 0:
+ repetead_numbers_counter = 1
+ current_number = nums[0]
+
+ for number in range(1, nums_length):
+ if current_number == nums[number]:
+ repetead_numbers_counter += 1
+ elif current_number != -1:
+ result += get_letter_from_number_and_counter(current_number,repetead_numbers_counter)
Слагай интервал след запетая.
+ current_number = nums[number]
+ repetead_numbers_counter = 1
+ else:
+ current_number = nums[number]
+ repetead_numbers_counter = 1
+ if current_number != -1:
+ result += get_letter_from_number_and_counter(current_number,repetead_numbers_counter)
+ return result.upper()
+
+def get_number_and_times(position_of_letter_in_alphabet):
+ number_to_add = 2 #starting from 2, because of the telephone 'A'
Прието е коментарите да се отделят от # с интервал. #PEP8
+ number_of_times = 0
+ if position_of_letter_in_alphabet < 15:
Иаползваш доста литерали. Или използвай ord(), за да ги вземеш динамично, или ги деифнирай като константи. Иначе са просто магически стойности в кода ти и не е ясно откъде идват.
+ number_of_times = position_of_letter_in_alphabet % 3 + 1
+ number_to_add += position_of_letter_in_alphabet // 3
+ elif position_of_letter_in_alphabet < 19:
+ number_of_times = (position_of_letter_in_alphabet - 15) % 4 + 1
+ number_to_add += 5
+ elif position_of_letter_in_alphabet < 22:
+ number_of_times = (position_of_letter_in_alphabet - 19) % 3 + 1
+ number_to_add += 6
+ elif position_of_letter_in_alphabet < 26:
+ number_of_times = (position_of_letter_in_alphabet - 22) % 4 + 1
+ number_to_add += 7
+ return number_to_add, number_of_times
+
+def get_list_from_letter(letter):
+ result = []
+ normalized_letter = letter.lower()
+
+ if normalized_letter == ' ':
+ result.append(0)
+ return result
+
+ position_of_letter_in_alphabet = ord(normalized_letter) - ord('a')
+ number_to_add, number_of_times = get_number_and_times(position_of_letter_in_alphabet)
+
+
+ for times in range(0,number_of_times):
Или пък result.extend([number_to_add] * number_of_times)
+ result.append(number_to_add)
+
+ return result
+
+def text_to_nums(text):
+
+ result = []
+ text_length = len(text)
+
+ if text_length > 0:
+ previous_letter = text[0]
+ result += get_list_from_letter(previous_letter)
+
+ for position_of_letter in range(1,text_length):
+ if text[position_of_letter] == previous_letter:
+ result.append(-1)
+ else:
+ previous_letter = text[position_of_letter]
+
+ result += get_list_from_letter(text[position_of_letter])
+ return result
+
+def nums_to_angle(nums):
+ result = 0
+ for number in nums:
+ if number == 0:
+ result += 300
+ else:
+ result += number*30
Слагай интервал около * и други подобни аритметични оператори.
+ result %= 360
+ return result
+
+def angles_to_nums(angles):
+ result = []
+ PI = 360
+ for angle in angles:
+ angle_after_checks = 0;
+ angle_after_checks = angle %360
+
+ if angle < 0 :
+ angle_after_checks+= PI
+
+
+ if angle_after_checks % 30 > 15:
+ normalized_angle = angle%PI + (angle%PI)%30
+
+ else:
+ normalized_angle = angle%PI - (angle%PI)%30
+
+ if normalized_angle == 300:
+ result.append(normalized_angle)
+ elif normalized_angle <= 330 and normalized_angle != 0:
+ number_to_append = normalized_angle//30
+ result.append(number_to_append)
+ return result
+
+def is_phone_tastic(word):
+ word_to_nums = text_to_nums(word)
+ normalized_result = nums_to_angle(word_to_nums)
+
+ word_length = len(word)
+
+ if normalized_result % word_length == 0:
Можеш просто return normalized_result % word_length == 0
+ return True
+
+ return False
+
Съветвам те да изтестваш граничните стойности. Според мен имаш пропуски с тях.
А защо не използваш директно
len(nums)? Хем спестяваш променлива, хем е по-кратко.